damage/JPushover11
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Sonar refactorings

Browse Source
This commit is contained in:
Sven Kubiak 2022-02-04 16:01:22 +01:00
parent d9cde1f429
commit 91b771355b
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/java/de/svenkubiak/jpushover/apis/OpenClient.java
View File

@ -64,13 +64,13 @@ public class OpenClient {
.POST(HttpRequest.BodyPublishers.ofString(params.toString())) .POST(HttpRequest.BodyPublishers.ofString(params.toString()))
.build(); .build();
PushoverResponse pushoverResponse = PushoverResponse.create().isSuccessful(false); var pushoverResponse = PushoverResponse.create().isSuccessful(false);
try { try {
HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString()); HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString());
pushoverResponse pushoverResponse
.httpStatus(response.statusCode()) .httpStatus(response.statusCode())
.response(response.body()) .response(response.body())
.isSuccessful((response.statusCode() == 200) ? true : false); .isSuccessful(response.statusCode() == 200);
} catch (IOException | InterruptedException e) { } catch (IOException | InterruptedException e) {
Thread.currentThread().interrupt(); Thread.currentThread().interrupt();
throw new JPushoverException("Pushover Login failed", e); throw new JPushoverException("Pushover Login failed", e);
@ -163,13 +163,13 @@ public class OpenClient {
.POST(HttpRequest.BodyPublishers.ofString(params.toString())) .POST(HttpRequest.BodyPublishers.ofString(params.toString()))
.build(); .build();
PushoverResponse pushoverResponse = PushoverResponse.create().isSuccessful(false); var pushoverResponse = PushoverResponse.create().isSuccessful(false);
try { try {
HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString()); HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString());
pushoverResponse pushoverResponse
.httpStatus(response.statusCode()) .httpStatus(response.statusCode())
.response(response.body()) .response(response.body())
.isSuccessful((response.statusCode() == 200) ? true : false); .isSuccessful(response.statusCode() == 200);
} catch (IOException | InterruptedException e) { } catch (IOException | InterruptedException e) {
Thread.currentThread().interrupt(); Thread.currentThread().interrupt();
throw new JPushoverException("Failed to delete messages", e); throw new JPushoverException("Failed to delete messages", e);
@ -237,7 +237,7 @@ public class OpenClient {
.POST(HttpRequest.BodyPublishers.ofString(params.toString())) .POST(HttpRequest.BodyPublishers.ofString(params.toString()))
.build(); .build();
PushoverResponse pushoverResponse = PushoverResponse.create().isSuccessful(false); var pushoverResponse = PushoverResponse.create().isSuccessful(false);
try { try {
HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString()); HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString());
pushoverResponse pushoverResponse
@ -258,7 +258,7 @@ public class OpenClient {
* @return true if close was successful, false otherwise * @return true if close was successful, false otherwise
*/ */
public boolean close() { public boolean close() {
boolean closed = false; var closed = false;
if (webSocket != null) { if (webSocket != null) {
webSocket.sendClose(WebSocket.NORMAL_CLOSURE, "ok"); webSocket.sendClose(WebSocket.NORMAL_CLOSURE, "ok");
closed = webSocket.isInputClosed() && webSocket.isOutputClosed(); closed = webSocket.isInputClosed() && webSocket.isOutputClosed();