From 91b771355b19e68b833353d9ee179d3f3dd64ae0 Mon Sep 17 00:00:00 2001
From: Sven Kubiak <sk@svenkubiak.de>
Date: Fri, 4 Feb 2022 16:01:22 +0100
Subject: [PATCH] Sonar refactorings

---
 .../de/svenkubiak/jpushover/apis/OpenClient.java     | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/main/java/de/svenkubiak/jpushover/apis/OpenClient.java b/src/main/java/de/svenkubiak/jpushover/apis/OpenClient.java
index 7eea694..ef20728 100644
--- a/src/main/java/de/svenkubiak/jpushover/apis/OpenClient.java
+++ b/src/main/java/de/svenkubiak/jpushover/apis/OpenClient.java
@@ -64,13 +64,13 @@ public class OpenClient {
                 .POST(HttpRequest.BodyPublishers.ofString(params.toString()))
                 .build();
         
-        PushoverResponse pushoverResponse = PushoverResponse.create().isSuccessful(false);
+        var pushoverResponse = PushoverResponse.create().isSuccessful(false);
         try {
             HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString());
             pushoverResponse
                 .httpStatus(response.statusCode())
                 .response(response.body())
-                .isSuccessful((response.statusCode() == 200) ? true : false);
+                .isSuccessful(response.statusCode() == 200);
         } catch (IOException | InterruptedException e) {
             Thread.currentThread().interrupt();
             throw new JPushoverException("Pushover Login failed", e);
@@ -163,13 +163,13 @@ public class OpenClient {
                 .POST(HttpRequest.BodyPublishers.ofString(params.toString()))
                 .build();
 
-        PushoverResponse pushoverResponse = PushoverResponse.create().isSuccessful(false);
+        var pushoverResponse = PushoverResponse.create().isSuccessful(false);
         try {
             HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString());
             pushoverResponse
                 .httpStatus(response.statusCode())
                 .response(response.body())
-                .isSuccessful((response.statusCode() == 200) ? true : false);
+                .isSuccessful(response.statusCode() == 200);
         } catch (IOException | InterruptedException e) {
             Thread.currentThread().interrupt();
             throw new JPushoverException("Failed to delete messages", e);
@@ -237,7 +237,7 @@ public class OpenClient {
                 .POST(HttpRequest.BodyPublishers.ofString(params.toString()))
                 .build();
 
-        PushoverResponse pushoverResponse = PushoverResponse.create().isSuccessful(false);
+        var pushoverResponse = PushoverResponse.create().isSuccessful(false);
         try {
             HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString());
             pushoverResponse
@@ -258,7 +258,7 @@ public class OpenClient {
      * @return true if close was successful, false otherwise
      */
     public boolean close() {
-        boolean closed = false;
+        var closed = false;
         if (webSocket != null) {
             webSocket.sendClose(WebSocket.NORMAL_CLOSURE, "ok");
             closed = webSocket.isInputClosed() && webSocket.isOutputClosed();